Change libomqwt to shared library. #11103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This reverts changes made in OpenModelica#9939 and OpenModelica#9956. - It should be a shared library (a DLL on Windows at least) because it is used by both `libOMPlotLib.dll` and `OMNoteBook.exe`. However, `OMNoteBook.exe` links to `libOMPlotLib.dll` as well. CMake will add both `libOMPlotLib.dll` and `libomqwt.a` to the linking commandline of `OMNoteBook.exe` and that causes duplicates on some configurations (e.g. using `clang` on `OMDev`. Curiously the issue does not occur with `gcc` on `OMDev`). - Another way to fix this problem would be to make the linking by `libOMPlotLib.dll` to static `libomqwt.a` a PRIVATE link (in CMake terms.) However, that will require us to manually add the definitions and include directives needed to use `libomqwt.a` by `OMNoteBook.exe` (think of it like `OMNoteBook.exe` uses both `libOMPlotLib.dll` and `libomqwt.a`, not just `libOMPlotLib.dll`). So the most logical and straightforward fix is to make `libomqwt` a shared lib.
mahge
added
COMP/Build System
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts changes made in Build qwt as a static library. #9939 and Fix Windows CMake build. #9956.
It should be a shared library (a DLL on Windows at least) because it is used by both
libOMPlotLib.dllandOMNoteBook.exe. However,OMNoteBook.exelinks tolibOMPlotLib.dllas well. CMake will add bothlibOMPlotLib.dllandlibomqwt.ato the linking commandline ofOMNoteBook.exeand that causes duplicates on some configurations (e.g. usingclangonOMDev. Curiously the issue does not occur withgcconOMDev).Another way to fix this problem would be to make the linking by
libOMPlotLib.dllto staticlibomqwt.aa PRIVATE link (in CMake terms.) However, that will require us to manually add the definitions and include directives needed to uselibomqwt.abyOMNoteBook.exe(think of it likeOMNoteBook.exeuses bothlibOMPlotLib.dllandlibomqwt.a, not justlibOMPlotLib.dll). So the most logical and straightforward fix is to makelibomqwta shared lib.