Fix for memory leak in fmi2GetFMUstate (#11233)

- De-allocate old FMUstate object before updating reference with newly allocated object.
OpenModelica · Sep 27, 2023 · 6e4fded · 6e4fded
1 parent 865f737
commit 6e4fded
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/OMCompiler/SimulationRuntime/fmi/export/openmodelica/fmu2_model_interface.c.inc b/OMCompiler/SimulationRuntime/fmi/export/openmodelica/fmu2_model_interface.c.inc
@@ -1362,6 +1362,10 @@ fmi2Status fmi2GetFMUstate(fmi2Component c, fmi2FMUstate* FMUstate)
   //printRingBufferSimulationData(fmudata->simulationData, fmudata); // original ringBuffer data
   //printRingBufferSimulationData(internal_state->simulationData, fmudata); // copied ringBuffer data
 
+  /* release previous fmu state if existent */
+  /* TODO: ideally, previous state's memory should be re-used instead of re-allocation */
+  if (*FMUstate != NULL) fmi2FreeFMUstate(c, FMUstate);
+
   // return the fmu state
   *FMUstate = (fmi2FMUstate) internal_state;
   return fmi2OK;