Skip to content

Commit

Permalink
Define the common config variables in the Makefiles. (#9002)
Browse files Browse the repository at this point in the history
  - Define the common configuration variables globally on the Makefile. 
    This way anything invoked downwards from this Makefile can pick up 
    these variables without us having to set them for every sub invocation manually.

    If we do not do this, the sub-invocations will pick up these values 
    from the environment  and this leads to some inconsistencies that 
    will be difficult to track down.
  • Loading branch information
mahge committed May 23, 2022
1 parent 3cc8deb commit dfa336d
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions Makefile.in
Expand Up @@ -2,6 +2,15 @@

defaultMakefileTarget = Makefile.unix

host=@host@
host_short=@host_short@
CC=@CC@
CXX=@CXX@
CPPFLAGS=@CPPFLAGS@
CFLAGS=@CFLAGS@
CXXFLAGS=@CXXFLAGS@
LDFLAGS=@LDFLAGS@

CMAKE = @CMAKE@
# Use the system's default cmake if nothing is passed to configure script, i.e., no CMAKE=<some_path> is specified
ifeq ($(CMAKE),)
Expand Down

0 comments on commit dfa336d

Please sign in to comment.