Define the common config variables in the Makefiles. #9002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahge
added
the
COMP/Build System
- Define these variables globally on the Makefile. This way anything
invoked downwards from this Makefile can pick up these variables
without us having to set them for every sub invocation manually.
Specifying them manually is prone to overlooking them and this leads
to some inconsistencies that will be difficult to track down.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define the common configuration variables globally on the Makefile.
This way anything invoked downwards from this Makefile can pick up
these variables without us having to set them for every sub invocation manually.
If we do not do this, the sub-invocations will pick up these values
from the environment and this leads to some inconsistencies that
will be difficult to track down.