Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model instance api call fails without any error #10069

Closed
adeas31 opened this issue Jan 18, 2023 · 0 comments · Fixed by #10070
Closed

Model instance api call fails without any error #10069

adeas31 opened this issue Jan 18, 2023 · 0 comments · Fixed by #10070
Assignees
@perost
Labels
COMP/GUI/InstBased Interface Issues with new instantiation-based OMEdit feature
Milestone
1.21.0

Comments

@adeas31
Copy link
Member

adeas31 commented Jan 18, 2023

Description

If the model contains the inner world component then the model instance api call fails.

Steps to Reproduce

Run the following script,

loadString("model M
  inner Modelica.Mechanics.MultiBody.World world annotation(
    Placement(visible = true, transformation(origin = {26, 4}, extent = {{-10, -10}, {10, 10}}, rotation = 0)));
equation

annotation(
    uses(Modelica(version = \"4.0.0\")));
end M;");
getErrorString();
getModelInstance(M, true);
getErrorString();

Expected Behavior

Should return the model instance json.
@adeas31 adeas31 added the COMP/GUI/InstBased Interface Issues with new instantiation-based OMEdit feature label Jan 18, 2023
perost added a commit to perost/OpenModelica that referenced this issue Jan 18, 2023
@perost
Fix extends of builtin type in getModelInstance
79427cc 
- Set the `isDerived` class to `true` when building instance trees for
  extends, otherwise extends of builtin types are incorrectly optimized
  away and cause issues later on.

Fixes OpenModelica#10069
@perost perost mentioned this issue Jan 18, 2023
Merged
perost added a commit that referenced this issue Jan 18, 2023
@perost
Fix extends of builtin type in getModelInstance (#10070)
a9f36c0 
- Set the `isDerived` class to `true` when building instance trees for
  extends, otherwise extends of builtin types are incorrectly optimized
  away and cause issues later on.

Fixes #10069
@casella casella added this to the 1.21.0 milestone Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@perost perost

Labels
COMP/GUI/InstBased Interface Issues with new instantiation-based OMEdit feature
Projects
None yet
Milestone
1.21.0
Development

Successfully merging a pull request may close this issue.

Fix extends of builtin type in getModelInstance perost/OpenModelica
3 participants
@adeas31 @casella @perost