Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modifying parameters a second time in parmeter dialog does not work correctly. #10149

Closed
niklwors opened this issue Feb 3, 2023 · 0 comments · Fixed by #10191
Closed

Modifying parameters a second time in parmeter dialog does not work correctly. #10149

niklwors opened this issue Feb 3, 2023 · 0 comments · Fixed by #10191
Assignees
@adeas31
Labels
COMP/GUI/InstBased Interface Issues with new instantiation-based OMEdit feature COMP/GUI/OMEdit Issue and pull request related to OMEdit
Projects
Improvements for BR

Comments

@niklwors
Copy link
Contributor

niklwors commented Feb 3, 2023 •
edited

Description

If you want to modify parameters in the parameter dialog of the OMEdit and the new instantiation-based UI a second time, the parameter values are reset.

Steps to Reproduce

Load the package Rexroth_Generic\package.mo
Drag and drop the component Rexroth_Generic.Hydraulics.Cylinders.SingleRodCylinder onto a new sheet.
Open the paramter dialog and modify this paramter:
picture 1:
remodify1

close the dialog and open it again and change this paramter:
pciture 2:
remodify2

After closing and reopening the dialog, it looks like this:

picture 3:
remodify3

Expected Behavior

The paramters should not reset.

Screenshots

Version and OS

  • OpenModelica Version: v1.21.0-dev-215-gfbc4a47daf
  • OS: Windows 10, 64 bit
  • MSL 4.0.0
  • BRSL 2.2.1

Additional Context
@niklwors niklwors added COMP/GUI/OMEdit Issue and pull request related to OMEdit COMP/GUI/InstBased Interface Issues with new instantiation-based OMEdit feature labels Feb 3, 2023
@niklwors niklwors mentioned this issue Feb 3, 2023
Closed
@adeas31 adeas31 self-assigned this Feb 3, 2023
@adeas31 adeas31 added this to Top Priority in Improvements for BR Feb 10, 2023
@adeas31 adeas31 mentioned this issue Feb 10, 2023
Merged
adeas31 added a commit to adeas31/OpenModelica that referenced this issue Feb 10, 2023
@adeas31
Do not remove the element modifiers
02998ac 
Fixes OpenModelica#10148, fixes OpenModelica#10149
Since we only update the modified modifiers so there is no point in removing all existing modifiers
adeas31 added a commit that referenced this issue Feb 13, 2023
@adeas31
Do not remove the element modifiers (#10191)
6b3eaf5 
Fixes #10148, fixes #10149
Since we only update the modified modifiers so there is no point in removing all existing modifiers
Improvements for BR automation moved this from Top Priority to Done Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adeas31 adeas31

Labels
COMP/GUI/InstBased Interface Issues with new instantiation-based OMEdit feature COMP/GUI/OMEdit Issue and pull request related to OMEdit
Projects
Improvements for BR
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not remove the element modifiers adeas31/OpenModelica
2 participants
@adeas31 @niklwors