Disabling stdout and assert log in simulation setup

[AnHeuermann]

Description

In #10426 I wanted to disable all warnings as well as the stdout log in OMEdit.
I noticed, that the Logging section of the Simulation Setup->Simulation Flags doesn't show that stdout and assert are always active and you can't deactivate them by removing a tick (there is none, see attached screenshot).

I had to add -lv=-stdout to disable stdout log, but then got a warning, that -lv was specified twice:

stdout            | warning | Command line option 'lv' specified again. Value has been overriden from 'LOG_STATS' to '-stdout'. 

Steps to Reproduce

Open any model in OMEdit and open Simulation Setup->Simulation Flags.

Expected Behavior

• Mark stdout and assert as active with a tick.
• When removing the ticks add simulation flags -lv=-stdout or -lv=-assert.

Screenshots

Version and OS

• OpenModelica Version: v1.21.0-dev-318-gd7cb3a8558 (64-bit)
• OS: Windows 11

[rfranke]

This breaks the C++ runtime. Any simulation fails now with:

Simulation stopped with error in model factory: log-settings flags not supported: stdout,assert,LOG_STATS  

The problem is that OMEdit settings had been identified with the prefix LOG_ so far. Bad that stdout and even more -stdout break this pattern.

Can't "stdout,assert," be omitted in the call args if the boxes stdout and assert are checked per default?

Nothing would mean that they are enabled. They can be disabled with -stdout,-assert. Currently C++ also fails when unchecking the boxes stdout and assert:

Simulation stopped with error in model factory: log-settings flags not supported: -stdout,-assert,LOG_STATS  

Meaning that currently there is no way to use the C++ runtime from OMEdit.

[casella]

@rfranke this does not affect the 1.21.0 release, right?

[rfranke]

Yes, hopefully only a short living nuisance in the 1.22 dev branch.

Btw. internally the C runtime uses the same syntax with LOG_ prefix also for stdout and assert. Just the command line options have been changed to lower case and without prefix.

OpenModelica/OMCompiler/SimulationRuntime/c/simulation/simulation_runtime.cpp

Lines 143 to 151 in 92b6780

	/* default activated, but it can be disabled with -stdout or -assert */
	useStream[LOG_STDOUT] = 1;
	useStream[LOG_ASSERT] = 1;
	if(flags->find("LOG_ALL", 0) != string::npos)
	{
	for(i=1; i<SIM_LOG_MAX; ++i)
	useStream[i] = 1;
	}

The C++ runtime would understand --log-settings all=error to suppress anything but error messages -- this is the default setting.

[adeas31]

@AnHeuermann can you fix the stdout and assert logs to use the LOG_ prefix like others?

[AnHeuermann]

You mean instead of -lv=assert using -lv=LOG_ASSERT?

[adeas31]

Yes

[AnHeuermann]

@rfranke the location in the C runtime where we check if we have - in front of the log flags: https://github.com/OpenModelica/OpenModelica/blob/master/OMCompiler/SimulationRuntime/c/simulation/simulation_runtime.cpp#L179-L183

I guess you can add something similar for the C++ runtimein OMCFactory.cpp (I think).

[rfranke]

The above commits and 8006f5b fix it. Thank you @AnHeuermann and @adeas31.