-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifiers applied to components of an extended model are not shown in the parameter dialog #10864
Comments
Fixes OpenModelica#10864 Check the complete list instead of just looking the first value. Stop when value is found.
Fixes #10864 Check the complete list instead of just looking the first value. Stop when value is found.
Thanks @adeas31! @matteodepascali, please check that you can now use your library with the latest nightly build. If there are any issues, please report them here. |
Thank you, @adeas31! |
Here is an updated MWE: package TestInheritedParameter
model M
parameter Real p = 1;
parameter Real q = 10;
equation
end M;
model S1
M m(p = 2, q = 20)
annotation(
Placement(visible = true,
transformation(origin = {-10, -2}, extent = {{-10, -10}, {10, 10}},
rotation = 0)));
equation
end S1;
model S2
extends TestInheritedParameter.S1(m(p = 3, q = 30));
equation
end S2;
model S3
extends TestInheritedParameter.S2(m(p = 3));
equation
end S3;
end TestInheritedParameter; When double-clicking on m in S3:
@perost, I guess this information should arrive to OMEdit straight from the instantiation API, can you please check that? Thanks! |
Thanks @adeas31! @matteodepascali please check with tomorrow's nightly build. |
Thank you @adeas31, I confirm the new nightly is fine and the bug is solved! |
Steps to Reproduce
open the attached InitBlocks.zip package
open
InitBlocks.Examples.Tests.WaterHeater.TestWaterHeaterStepForward
in OMEditthe model contains the following code:
However, if I double-click on the salmon-hued
outputBlock
,y_norm
is displayed with its default inherited valuey_des
. If I now type in another value, e.g. 400, this is correctly inserted in the modifier, but the parameter editing window still displaysy_des
.I guess this is a problem with OMEdit, not with the API, but I'm not sure. @adeas31, @perost, could you please check?
Keeping @matteodepascali in the loop
Thanks!
The text was updated successfully, but these errors were encountered: