Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphical view size of connectors version 1.22 #11380

Closed
jobehrendt opened this issue Oct 16, 2023 · 6 comments · Fixed by #11393
Closed

Graphical view size of connectors version 1.22 #11380

jobehrendt opened this issue Oct 16, 2023 · 6 comments · Fixed by #11393
Assignees
Labels
bug COMP/GUI/OMEdit Issue and pull request related to OMEdit
Milestone

Comments

@jobehrendt
Copy link

Description

This bug is relevant for the version 1.22 which was delivered as stable version for some weeks.
In the graphical view the connectors of submodels were display very big so that no further editing is possible. I have reproduced this error in the Linux (Debian bookworm) and Windows 10 version as well.

Steps to reproduce

I am providing you with an example code (as zip) and two screenshots to
Tracer_Graph.zip
Versin2 21
Version1 22

I hope you can fix this issue. Thanks for providing us with OpenModelica.
Best regards
Joachim Behrendt

Example script reproduceBug.mos:

getVersion(); getErrorString();
loadModel(Modelica,{"4.0"}); getErrorString();
loadFile("path/to/MyLibrary");getErrorString();
setCompilerFlags("-d=optdaedump");getErrorString();
simulate(MyLibrary.MyModel); getErrorString();

You need to run the script from the command line interface. On Linux, you can use your favourite shell, cd to the directory where the .mos file is located and run

$ omc reproduceBug.mos

On Windows, start the command line interface (right-click on the start menu, then run the CMD program), cd to the directory where the .mos file is located and type

C:\MyDirectory>"C:\Program Files\OpenModelica1.18.0\bin\omc.exe" reproduceBug.mos

You may need to adapt the path based on the actual installed version of OpenModelica.

We really 💖 minimal working examples. If you can provide a MWE that shows the problem, instead of your original model, reproducing the bug is more straightforward and we can respond faster.

Expected behavior

A clear and concise description of what you expected to happen.

Screenshots

If applicable, add screenshots to help explain your problem.

Additional files

You can add additional files via drag-and-drop, e.g. for your minimal working example. Please note that GitHub does not accept .mo and .mos attachments, so you can either zip the example files and attach the .zip file, or add .txt to the extension of a simple .mo or .mos file.

You can also use File->Save Total in OMEdit to save a model and all its dependencies to a single file, so you don't need to provide all the libraries you are using. If your model is sensitive or confidential, you can use the obfuscation option, that removes all documentation and scrambles the variable names, preventing reverse-engineering.

Version and OS

  • OpenModelica Version [run omc --version or check Help->About OMEdit from OMEdit]
  • Versions of used Modelica libraries if applicable
  • OS: [e.g. Windows 10, 64 bit]

Additional context

Add any other context about the problem here.

@adeas31 adeas31 self-assigned this Oct 16, 2023
@adeas31 adeas31 added bug COMP/GUI/OMEdit Issue and pull request related to OMEdit labels Oct 16, 2023
@casella
Copy link
Contributor

casella commented Oct 17, 2023

@adeas31 maybe this could still end up in 1.22.0?

@adeas31
Copy link
Member

adeas31 commented Oct 17, 2023

Yes. This is happening because the connectors have a line thickness of 3 instead of default 0.25. I don't know yet how to fix it.

adeas31 added a commit to adeas31/OpenModelica that referenced this issue Oct 18, 2023
adeas31 added a commit that referenced this issue Oct 18, 2023
adeas31 added a commit to adeas31/OpenModelica that referenced this issue Oct 18, 2023
adeas31 added a commit to adeas31/OpenModelica that referenced this issue Oct 18, 2023
adeas31 added a commit to adeas31/OpenModelica that referenced this issue Oct 18, 2023
adeas31 added a commit that referenced this issue Oct 18, 2023
@casella
Copy link
Contributor

casella commented Oct 19, 2023

@adeas31 should we make a beta.5, or can we trust that it works out of the box?

Maybe you could just compile the maintenance branch yourself and double-check it works.

@adeas31
Copy link
Member

adeas31 commented Oct 19, 2023

We can do a beta5. I already tested the maintenance branch.

@jobehrendt
Copy link
Author

with the beta 6 it works out better, Thanks for considering my comment.

@casella
Copy link
Contributor

casella commented Oct 24, 2023

Thank you for pointing this out! 👍

@casella casella added this to the 1.22.0 milestone Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug COMP/GUI/OMEdit Issue and pull request related to OMEdit
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants