Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OMEdit layers connection in top instead of bottom layer, and does not remove connectors #11401

Closed
mwetter opened this issue Oct 18, 2023 · 2 comments · Fixed by #11404
Closed
Assignees

Comments

@mwetter
Copy link

mwetter commented Oct 18, 2023

Description

Consider Modelica.Fluid.Examples.DrumBoiler.DrumBoiler shown below.

The connections should be below the icons, otherwise the graphic looks strange. See for example feedback or pump.

Also, the conditionally removed connectors of the pump should be removed.

Screenshots

image

Version and OS

OpenModelica 1.23.0~dev-59-g7a41456
OMSimulator 2.1.1~241-g54ebbdc-linux-notlm-debug

Additional Context

This is with "Disable new instance-based graphical editing" selected, which seems to be needed to remove the warnings of #11388

@adeas31
Copy link
Member

adeas31 commented Oct 19, 2023

This is again related to instance-based API. I fixed the issue for old API in #11404 for now. We don't focus on fixing issues related to the old API as it will be removed in the future version.

Also, the conditionally removed connectors of the pump should be removed.

The conditional connectors are not supported by the old API. Use the new instance-based API.

@casella
Copy link
Contributor

casella commented Oct 19, 2023

@mwetter the old interface is kept as a fallback option for those cases when the new one fails (as it happened during the tutorial in Aachen), but it's not otherwise meant to be used anymore. If there are issues with the new interface, they should be reported and fixed asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants