Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with connection between non-expandable and expandable connector in OMEdit #12151

Closed
casella opened this issue Mar 26, 2024 · 1 comment · Fixed by #12156
Closed

Issue with connection between non-expandable and expandable connector in OMEdit #12151

casella opened this issue Mar 26, 2024 · 1 comment · Fixed by #12156
Assignees
@adeas31
Labels
COMP/GUI/OMEdit Issue and pull request related to OMEdit
Milestone
1.23.0

Comments

@casella
Copy link
Contributor

casella commented Mar 26, 2024

Steps to Reproduce

  • Load the TestExpandableConnectors2.zip package
  • Open Reactions.Reaction1
  • Go to the diagram layer
  • Connect the thermalGateway port to the outside port connector
  • Select port.hp
  • The correct connect(thermalGateway.hp, port.hp); statement is displayed
  • Unfortunately, when you click OK, a bogus connect(hp.hp, port.hp); statement is added to the code of Reaction1
  • Then, of course, the frontend complains about hp.hp not being found

Expected Behaviour

The correct statement connect(thermalGateway.hp, port.hp); should be added to Reaction1

Expected Behavior

Screenshots

Version and OS

  • OpenModelica Version: [e.g. omc --version or Help->About OMEdit from OMEdit]
  • OS: [e.g. Windows 10, 64 bit]
  • Versions of used Modelica libraries if applicable

Additional Context
@casella casella added the COMP/GUI/OMEdit Issue and pull request related to OMEdit label Mar 26, 2024
@casella casella added this to the 1.23.0 milestone Mar 26, 2024
@casella
Copy link
Contributor Author

casella commented Mar 26, 2024

Adding @albertoleva to the loop

@adeas31 adeas31 mentioned this issue Mar 26, 2024
Merged
adeas31 added a commit to adeas31/OpenModelica that referenced this issue Mar 26, 2024
@adeas31
Use the correct parent name of the connector
91480ef 
Fixes OpenModelica#12151
adeas31 added a commit that referenced this issue Mar 26, 2024
@adeas31
Use the correct parent name of the connector (#12156)
62bda87 
Fixes #12151
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adeas31 adeas31

Labels
COMP/GUI/OMEdit Issue and pull request related to OMEdit
Projects
No open projects
Release 1.23.0 plan
Status: Done
Milestone
1.23.0
Development

Successfully merging a pull request may close this issue.

Use the correct parent name of the connector adeas31/OpenModelica
2 participants
@adeas31 @casella