Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version header to Base Modelica output #12458

Closed
casella opened this issue May 22, 2024 · 1 comment
Closed

Add version header to Base Modelica output #12458

casella opened this issue May 22, 2024 · 1 comment
Assignees
@perost
Labels
COMP/Base Modelica COMP/OMC/Frontend Issue and pull request related to the frontend
Milestone
1.24.0

Comments

@casella
Copy link
Contributor

casella commented May 22, 2024 •
edited
Loading

Following the proposed Base Modelica grammar, the first line of the Base Modelica output should contain a version header line. For the time being I would add

//! base 0.1.0

to the first line of the Base Modelica output, as shown in the Modelica Conference paper.
@casella casella added COMP/Base Modelica COMP/OMC/Frontend Issue and pull request related to the frontend labels May 22, 2024
@casella casella added this to the 1.24.0 milestone May 22, 2024
perost added a commit to perost/OpenModelica that referenced this issue May 23, 2024
@perost
Improve Base Modelica export
8cc4214 
- Add version header.
- Add experiment annotation.

Fixes OpenModelica#12457 and OpenModelica#12458
perost added a commit to perost/OpenModelica that referenced this issue May 23, 2024
@perost
Improve Base Modelica export
4f97707 
- Add version header.
- Add experiment annotation.

Fixes OpenModelica#12457 and OpenModelica#12458
@perost perost mentioned this issue May 23, 2024
Merged
perost added a commit to perost/OpenModelica that referenced this issue May 23, 2024
@perost
Improve Base Modelica export
0906e89 
- Add version header.
- Add experiment annotation.

Fixes OpenModelica#12457 and OpenModelica#12458
perost added a commit that referenced this issue May 23, 2024
@perost
Improve Base Modelica export (#12460)
c8e35cd 
- Add version header.
- Add experiment annotation.

Fixes #12457 and #12458
@perost
Copy link
Member

perost commented May 24, 2024

Fixed by #12460.

@perost perost closed this as completed May 24, 2024
adrpo pushed a commit to adrpo/OpenModelica that referenced this issue May 30, 2024
@perost @adrpo
Improve Base Modelica export (OpenModelica#12460)
dd79f30 
- Add version header.
- Add experiment annotation.

Fixes OpenModelica#12457 and OpenModelica#12458
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@perost perost

Labels
COMP/Base Modelica COMP/OMC/Frontend Issue and pull request related to the frontend
Projects
None yet
Milestone
1.24.0
Development

No branches or pull requests
2 participants
@casella @perost