Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GenerateMSLIcons.mos test creating svg's that doesn't look like the ones from OMEdit #7173

Closed
AnHeuermann opened this issue Feb 17, 2021 · 0 comments · Fixed by #8804
Closed

GenerateMSLIcons.mos test creating svg's that doesn't look like the ones from OMEdit #7173

AnHeuermann opened this issue Feb 17, 2021 · 0 comments · Fixed by #8804
Assignees
@adeas31
Milestone
1.19.0

Comments

@AnHeuermann
Copy link
Member

Description

The test GenerateMSLIcons.mos
 is generating SVG files that look different than the ones inside OMEdit.
I encountered the problem when changing the Modelica Standard Library to 4.0.0 in PR #7161.

Steps to reproduce

Checkout #7161 and run the test (with omc and not rtest) and look at the create svg's in ModelucaIcons/.

For example for Modelica.Mechanics.Rotational.Examples.Utilities.Spring we generate an svg that looks like this:
image

But in OMEdit it looks like this:
image

Version and OS

  • OpenModelica Version [OMCompiler v1.18.0-dev.50+g9c9f58ed4e]
  • MSL 4.0.0
  • OS: [Ubuntu Focal]
@AnHeuermann AnHeuermann changed the title GenerateMSLIcons.mos test creating svg's that doesn'T look like the ones from OMEdit GenerateMSLIcons.mos test creating svg's that doesn't look like the ones from OMEdit Feb 17, 2021
@AnHeuermann AnHeuermann mentioned this issue Feb 17, 2021
Merged
adeas31 added a commit to adeas31/OpenModelica that referenced this issue Apr 5, 2022
@adeas31
Fix the bitmap image source check and text horizontal alignment
b89da2b 
Fixes OpenModelica#7173
@adeas31 adeas31 mentioned this issue Apr 5, 2022
Merged
adeas31 added a commit that referenced this issue Apr 5, 2022
@adeas31
Fix the bitmap image source check and text horizontal alignment (#8804)
06a87ab 
Fixes #7173
@casella casella added this to the 1.19.0 milestone Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adeas31 adeas31

Labels
None yet
Projects
None yet
Milestone
1.19.0
Development

Successfully merging a pull request may close this issue.

Fix the bitmap image source check and text horizontal alignment adeas31/OpenModelica
3 participants
@adeas31 @casella @AnHeuermann