Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenModelica -cpu flag does not work for 1.18.0~dev-320-g1a21771-1 #7551

Closed
mjschuh opened this issue Jun 11, 2021 · 4 comments · Fixed by #7587
Closed

OpenModelica -cpu flag does not work for 1.18.0~dev-320-g1a21771-1 #7551

mjschuh opened this issue Jun 11, 2021 · 4 comments · Fixed by #7587
Assignees
@adeas31
Labels
bug
Milestone
1.18.0

Comments

@mjschuh
Copy link

mjschuh commented Jun 11, 2021

Checking the -cpu box with OMEdit 1.18.0~dev-320-g1a21771-1 in the Simulation Setup -> Simulation Flags window does not generate $cpu output. The -cpu option works fine in version 1.17.
@casella casella added this to the 1.18.0 milestone Jun 11, 2021
@casella casella added the bug label Jun 11, 2021
@casella
Copy link
Contributor

casella commented Jun 11, 2021

@adeas31, can you have a quick look? We should try to avoid regressions in the new release. Thanks!

@adeas31
Copy link
Member

adeas31 commented Jun 15, 2021

I am guessing this is because we recently changed to read the result variables from model_init.xml file instead of the model_res.mat file. @kabdelhak or @AnHeuermann does anyone of you can have a look at it? Just add the $cpu variable in the model_init.xml file when -cpu flag is set.

@sjoelund
Copy link
Member

We don't know if the -cpu flag will be set or not when generating the _init.xml. You know in OMEdit if you passed that flag or not.

@adeas31
Copy link
Member

adeas31 commented Jun 15, 2021

So then is probably just to generate a new node when -cpu is set. I will take care of it then.

@adeas31 adeas31 mentioned this issue Jun 15, 2021
Closed
23 tasks
adeas31 added a commit to adeas31/OpenModelica that referenced this issue Jun 21, 2021
@adeas31
Add $cpuTime variable to the variables list if cpu time flag is set
2205a03 
Fixes OpenModelica#7551
@adeas31 adeas31 mentioned this issue Jun 21, 2021
Merged
adeas31 added a commit that referenced this issue Jun 21, 2021
@adeas31
Add $cpuTime variable to the variables list if cpu time flag is set (#…
170459c 
…7587)

Fixes #7551
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adeas31 adeas31

Labels
bug
Projects
None yet
Milestone
1.18.0
Development

Successfully merging a pull request may close this issue.

Add $cpuTime variable to the variables list if cpu time flag is set adeas31/OpenModelica
4 participants
@sjoelund @adeas31 @casella @mjschuh