Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting a user model in OMEdit changes it to a system model #8731

Closed
perost opened this issue Mar 21, 2022 · 0 comments · Fixed by #8733
Closed

Converting a user model in OMEdit changes it to a system model #8731

perost opened this issue Mar 21, 2022 · 0 comments · Fixed by #8733
Assignees
Labels
COMP/GUI/OMEdit Issue and pull request related to OMEdit

Comments

@perost
Copy link
Member

perost commented Mar 21, 2022

Steps to Reproduce

  • Create a new model.
  • Open the text view and add annotation(uses(Modelica(version="3.2.3"))); to the model.
  • Right-click on the model in the libraries browser and select "Convert to newer versions of used libraries".
  • Choose to convert to Modelica 4.0.0 (in my case 4.0.0+maint.om).
  • Double-click on the model in the libraries browser to open it again, since OMEdit closes the converted model for some reason.
  • OMEdit now won't allow saving the model, and trying to edit it will show a warning that you're changing a system library class.

Expected Behavior

The model should keep the same behaviour as before it was converted, i.e. considered to be a user model that can be modified and saved.

Also, the same thing happens if the model is saved before converting it, but in that case OMEdit automatically saves the converted model over the original model which was a bit unexpected. I think it would be better if OMEdit left it up to the user to save the converted classes, but maybe that's hard to implement.

Version and OS

  • OpenModelica Version: master
  • OS: Linux 64-bit
@perost perost added the COMP/GUI/OMEdit Issue and pull request related to OMEdit label Mar 21, 2022
adeas31 added a commit to adeas31/OpenModelica that referenced this issue Mar 21, 2022
adeas31 added a commit to adeas31/OpenModelica that referenced this issue Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMP/GUI/OMEdit Issue and pull request related to OMEdit
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants