Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dictionary of variable names to output of linearize() function when using Python #8770

Closed
casella opened this issue Mar 28, 2022 · 3 comments
Assignees
Milestone

Comments

@casella
Copy link
Contributor

casella commented Mar 28, 2022

The current implementation of linearize() when using Python output only provides the ABCD matrices.

@naibafomsare proposed here to add a dictionary with names for inputs, outputs, and states. This should be done to get the same functionality as in the Matlab output

@arun3688
Copy link
Contributor

@casella the feature is implemented with this commit 62abb40

@casella
Copy link
Contributor Author

casella commented Mar 28, 2022

@naibafomsare, would you mind testing it with the next nigthly build and report? Thanks!

@casella casella modified the milestones: 1.20.0, 1.19.0 Mar 28, 2022
@naibafomsare
Copy link

@casella and @arun3688, I have tested the new code, and it seems to be working very well, thank you very much! I can simplify my code now.

The only observation I have is about the description of the new feature. @arun3688 did not add a dictionary, but just a list with the names of the variables in the appropriate order. Such a solution is better than the one I had proposed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants