Expressions in annotations with instance api

[adeas31]

Description

Right now the instance api just dumps the expressions in the annotation.

Steps to Reproduce

model IconVisible
parameter Boolean show=true;
annotation(
    Icon(graphics = {
    Rectangle(visible=not show, origin = {-40, 0}, extent = {{-20, 20}, {20, -20}}),
    Rectangle(visible=show,origin = {40, 0}, fillPattern = FillPattern.Solid, extent = {{-20, 20}, {20, -20}})}));
end IconVisible;

Calling getModelInstance(IconVisible) outputs,

Click to expand output

"{
  \"name\": \"IconVisible\",
  \"restriction\": \"model\",
  \"annotation\": {
    \"Icon\": {
      \"graphics\": [
        {
          \"$kind\": \"record\",
          \"name\": \"Rectangle\",
          \"elements\": [
            {
              \"$kind\": \"unary_op\",
              \"op\": \" not \",
              \"exp\": {
                \"$kind\": \"cref\",
                \"parts\": [
                  {
                    \"name\": \"show\"
                  }
                ]
              }
            },
            [
              -40,
              0
            ],
            0,
            [
              0,
              0,
              0
            ],
            [
              0,
              0,
              0
            ],
            {
              \"$kind\": \"enum\",
              \"name\": \"LinePattern.Solid\",
              \"index\": 2
            },
            {
              \"$kind\": \"enum\",
              \"name\": \"FillPattern.None\",
              \"index\": 1
            },
            0.25,
            {
              \"$kind\": \"enum\",
              \"name\": \"BorderPattern.None\",
              \"index\": 1
            },
            [
              [
                -20,
                20
              ],
              [
                20,
                -20
              ]
            ],
            0
          ]
        },
        {
          \"$kind\": \"record\",
          \"name\": \"Rectangle\",
          \"elements\": [
            {
              \"$kind\": \"cref\",
              \"parts\": [
                {
                  \"name\": \"show\"
                }
              ]
            },
            [
              40,
              0
            ],
            0,
            [
              0,
              0,
              0
            ],
            [
              0,
              0,
              0
            ],
            {
              \"$kind\": \"enum\",
              \"name\": \"LinePattern.Solid\",
              \"index\": 2
            },
            {
              \"$kind\": \"enum\",
              \"name\": \"FillPattern.Solid\",
              \"index\": 2
            },
            0.25,
            {
              \"$kind\": \"enum\",
              \"name\": \"BorderPattern.None\",
              \"index\": 1
            },
            [
              [
                -20,
                20
              ],
              [
                20,
                -20
              ]
            ],
            0
          ]
        }
      ]
    }
  },
  \"components\": [
    {
      \"name\": \"show\",
      \"type\": \"Boolean\",
      \"modifiers\": \"true\",
      \"value\": {
        \"binding\": true
      },
      \"prefixes\": {
        \"variability\": \"parameter\"
      }
    }
  ],
  \"source\": {
    \"filename\": \"C:/Users/adeas31/Desktop/ModelInstance/issue-6111.mo\",
    \"lineStart\": 1,
    \"columnStart\": 1,
    \"lineEnd\": 7,
    \"columnEnd\": 16
  }
}"

Expected Behavior

Output both the original expression and the evaluated value.

Additional Context

One idea is to improve the Expression class in OMEdit to evaluate such expressions. I am not sure about this but @perost knows more since he implemented it. Not sure if we can handle all cases with Expression class. For example, if the above model is used like this in another model,

model M
  IconVisible iconVisible(show=false)
    annotation (Placement(transformation(extent={{-74,-8},{-54,12}})));
  annotation (Icon(coordinateSystem(preserveAspectRatio=false)), Diagram(
        coordinateSystem(preserveAspectRatio=false)));
end M;

Then we need to apply the modifiers.

[perost]

For example, if the above model is used like this in another model,

model M
  IconVisible iconVisible(show=false)
    annotation (Placement(transformation(extent={{-74,-8},{-54,12}})));
  annotation (Icon(coordinateSystem(preserveAspectRatio=false)), Diagram(
        coordinateSystem(preserveAspectRatio=false)));
end M;

Then we need to apply the modifiers.

I'm not sure what the problem with that is, getModelInstance of M will apply the modifiers so as long as variable bindings are just changed it should be fine. But if modifiers are added or removed then we'll probably need to call getModelInstance again.

[adeas31]

We (me, @perost and @adrpo) had a meeting today and discussed how to solve this.

We will use the Expression class (as suggested by @perost) to evaluate using the value binding of the variable.