Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch connection list API #10042

Merged
merged 5 commits into from Feb 24, 2023
Merged

Fetch connection list API #10042

merged 5 commits into from Feb 24, 2023

Conversation

rahulp13
Copy link
Contributor

Implement the getConnectionList API that can retrieve the list of all connections at once including those within loops, by instantiating the model.

@mahge mahge requested a review from adeas31 January 19, 2023 19:54
@adeas31 adeas31 requested review from perost and removed request for adeas31 January 20, 2023 11:22
@adeas31
Copy link
Member

adeas31 commented Jan 20, 2023

@perost is better candidate for reviewing this.

@perost
Copy link
Member

perost commented Jan 20, 2023

Please add at least some simple testcase in testsuite/openmodelica/interactive-API too, otherwise we might break the API by accident and not notice it.

Also, what do you want this API for?

@rahulp13
Copy link
Contributor Author

I have an application with several components in an array, requiring exact connection info on which components in the array are connected. Also, getting all the connections at once might be better.

@rahulp13 rahulp13 requested a review from perost January 31, 2023 07:24
@adrpo
Copy link
Member

adrpo commented Feb 23, 2023

Ouch, it seems we did not merge this before the NFFlatten changed.
@rahulp13 or @perost can you fix the conflicts so we can merge this one?

@perost
Copy link
Member

perost commented Feb 23, 2023

Ouch, it seems we did not merge this before the NFFlatten changed. @rahulp13 or @perost can you fix the conflicts so we can merge this one?

I think I managed to fix the conflict, and I also fixed the if-statement added to flatten since it included too much (the execstat and dumpFlatModelDebug for flatten shouldn't depend on the flag for handling connections).

@adrpo
Copy link
Member

adrpo commented Feb 24, 2023

@perost thanks, I had a look also, it seems OK.

@adrpo adrpo merged commit a738ef5 into OpenModelica:master Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants