Improve handling of CLI and annotation flags/options. #10418
Conversation
mahge
added
COMP/OMC/Frontend
mahge
changed the title
- Consider `experiment` annotation when using omc on the CLI. - Consider `__OpenModelica_commandLineOptions` annotation when using omc on the CLI. - Consider flag `--newBackend` when specified on the CLI. These have required some restructuring of the translateModel workflow. There is still so much more that can be cleaned up and refactored to make more sense. Fixes OpenModelica#7860. Fixes OpenModelica#8122. Fixes OpenModelica#10142.
| flatString := NFFlatString; | ||
| elseif not runSilent then | ||
| (dae, funcs) := NFConvertDAE.convert(flatModel, funcTree); | ||
| flatString := DAEDump.dumpStr(dae, funcs); |
There was a problem hiding this comment.
For the new backend we could possibly use FlatModel.toString instead and avoid converting to DAE, since I assume we don't have any test cases that check the flat output with the new backend anyway. But it probably doesn't matter much.
There was a problem hiding this comment.
since I assume we don't have any test cases that check the flat output with the new backend anyway
Probably not. We can try it.
However, I think it is better to do that where the NF creates the valid flat Modelica string now. That is, the NF should generate some flat output based on the options it is given and return either the valid or normal flat Modelica code. Somewhere around here if possible. Then this can be changed to check if there is some output string from the NF and print that. OR even better the NF itself can dump it, although that can perhaps require a bit more adjustment in other places.
Improve handling of CLI and annotation flags/options.
experimentannotation when using omc on the CLI.__OpenModelica_commandLineOptionsannotation when using omc on the CLI.--newBackendwhen specified on the CLI.These have required some restructuring of the
translateModelworkflow. There is still so much more that can be cleaned up and refactored to make more sense.