Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NB] Use same lists for symbolic and numeric jac #10457

Merged
merged 7 commits into from
Jun 23, 2023

Conversation

phannebohm
Copy link
Contributor

The symbolic jacobian did not find the correct number of resultVars.

This caused random failures on @AnHeuermann's Windows machine.

@phannebohm phannebohm added the COMP/OMC/New Backend Issues and pull requests related to the new backend. label Mar 28, 2023
@phannebohm phannebohm self-assigned this Mar 28, 2023
@phannebohm phannebohm force-pushed the nb-jac-res-var branch 2 times, most recently from 498f332 to 59302d8 Compare June 21, 2023 15:55
phannebohm and others added 5 commits June 23, 2023 10:17
The symbolic jacobian did not find the correct number of `resultVars`.
- Rename JAC_DIFF_VAR to JAC_TMP_VAR
- Don't reverse columnEqns
phannebohm and others added 2 commits June 23, 2023 13:27
  - ODE/DAE filter by state derivative / algebraic
  - LS/NLS filter by residual / inner
@phannebohm phannebohm enabled auto-merge (squash) June 23, 2023 11:50
@phannebohm phannebohm merged commit 89ecd3f into OpenModelica:master Jun 23, 2023
2 checks passed
@phannebohm phannebohm deleted the nb-jac-res-var branch June 23, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMP/OMC/New Backend Issues and pull requests related to the new backend.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants