Minor fixes of CMake based configuration for portability. #10512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove unnecessary install of pdb file.
- We do not need it. Plus the location specified for it was not correct.
- Rename option to be more unique and descriptive.
- PCRE -> METIS_GKLIB_PCRE
- Use the pcre regex library for MSVC.
- There is no system regex library for MSVC. Instead we should use the
unofficial pcre port from vcpkg and tell Metis to use that for GKLib
regex needs.
mahge
added
the
COMP/Build System
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary install of pdb file.
Rename option to be more unique and descriptive.
Use the pcre regex library for MSVC.