Change OMCppOMCFactory to static library. #10515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This was overlooked and made different from the other build system
(the original CMake build for CPP runtime used by the OpenModelica
autoconf build.)
- Normally for Linux, macOS and MinGW this was insignificant. However,
for MSVC it matters because the library does not export any symbols.
For MSVC, when built as DLL, this implies that the library is not supposed
to be linked directly (it will only be loaded). So it will not generate
the import lib for it.
mahge
added
COMP/SimRT/C++
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was overlooked and made different from the other build system (the original CMake build for CPP runtime used by the OpenModelica autoconf build.)
Normally for Linux, macOS and MinGW this was insignificant. However, for MSVC it matters because the library does not export any symbols. For MSVC, when built as DLL, this implies that the library is not supposed to be linked directly (it will only be loaded). So it will not generate the import lib for it.