Select printf format specifier based on OS. #10738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Select the format printf specifier for modelica_integer based on the
OS. For Windows this should be defined to "%lld" because modelica_integer
is long long int on Windows. For other OSs, it should be "%ld".
- The generated code can be a little confusing. See discussions in
OpenModelica#10702 (comment)
for how it works and why it is done like this.
mahge
added
COMP/SimRT/C
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Select the format
printfspecifier formodelica_integerbased on the OS. For Windows this should be defined to"%lld"becausemodelica_integeris long long int on Windows. For other OSs, it should be"%ld".The generated code can be a little confusing. See discussions in Warnings in .bnd C code #10702 (comment) for how it works and why it is done like this.
Fixes #10702.