Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use _fseeki64 instead of fseek on Windows #10739

Merged
merged 1 commit into from
May 26, 2023
Merged

Use _fseeki64 instead of fseek on Windows #10739

merged 1 commit into from
May 26, 2023

Conversation

adeas31
Copy link
Member

@adeas31 adeas31 commented May 24, 2023

Allows loading files greater than 2GB

Related Issues

#8766

@adeas31 adeas31 requested a review from sjoelund May 24, 2023 15:44
@adeas31 adeas31 self-assigned this May 24, 2023
@adeas31 adeas31 mentioned this pull request May 24, 2023
Closed
@adeas31 adeas31 requested a review from mahge May 24, 2023 15:52
@adeas31 adeas31 mentioned this pull request May 24, 2023
Closed
mahge
mahge reviewed May 24, 2023
View reviewed changes
Copy link
Contributor

@mahge mahge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also other uses of fseek (a few more in SimulationRuntime/c directory itself). It might be better to fix all of them at the same time.

@adeas31 adeas31 enabled auto-merge (squash) May 25, 2023 07:24
@adeas31
Copy link
Member Author

adeas31 commented May 25, 2023

There are also other uses of fseek (a few more in SimulationRuntime/c directory itself). It might be better to fix all of them at the same time.

fseek should work in most cases.

@adeas31
Move the omc_fseek define to omc_file.h
d08218e 
Use _fseeki64 instead of fseek on Windows

Allows loading files greater than 2GB
@adeas31 adeas31 merged commit 96fe37f into OpenModelica:master May 26, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahge mahge mahge approved these changes

@sjoelund sjoelund Awaiting requested review from sjoelund

Assignees

@adeas31 adeas31

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adeas31 @mahge