Improve handling of record bindings

[perost]

• Don't evaluate non-structural parameters.
• Use tryEvalExp instead of evalExp when trying to evaluate record bindings, to hide any eventual error messages since failure is ok.
• Improve the function inlining by merging the inlining of record constructors with the inlining of normal function calls, and allowing forced inlining regardless of annotation.

Fixes #10812

[mahge]

This has not yet gone through the master regression tests (there is a bit of queue unfortunately), but I think it broke some Buildings models.

You can check the Buildings.Examples.Tutorial.Boiler.System1 model for example. There quite a few more Buildings models that fail the same way.

The issue is around this algorithm

vol.state_start := if size({vol.X_start[1:vol.Medium.nXi]}, 1) == 2 then
 Buildings.Examples.Tutorial.Boiler.System1.vol.Medium.ThermodynamicState(vol.p_start, vol.T_start, {vol.X_start[1]}) else
 Buildings.Examples.Tutorial.Boiler.System1.vol.Medium.ThermodynamicState(vol.p_start, vol.T_start, {vol.X_start[1], 1.0 - vol.X_start[1]});

Specifically, the problem is the {vol.X_start[1:vol.Medium.nXi]} expression which is a matrix.

The following model, which is as close as possible I can make it to the issue without omc optimizing away things, compiles fine

model Test
  Real a[2] = {time + 1, time + 2};
  Real b[1,2];
  Integer i;
algorithm
  i := if time < 1 then 2 else 3;
  b := {a[i-1:i]};
end Test;

Is there anything that you can see that might suggest that the expression {vol.X_start[1:vol.Medium.nXi]} is not getting the correct type?

I thought we were also replacing all slices on the RHS with for-iterator-array expressions. Maybe we are not traversing expressions inside an array ({...}) expression?
Never mind, this is actually not a slice.

[perost]

@mahge: I disabled the part that seems to be causing the issue in #10842. It seems inlining normal functions is causing some issue in this case, it creates the if-expression you mentioned which it then fails to evaluate and moves it to an initial equation because it can't split it.

I don't know what's going wrong, maybe the inlining is incorrect somehow. But that part isn't actually necessary for fixing the issue so I disabled it for now until I have time to take a better look at it.

[mahge]

Thanks. Hopefully, this makes it to tonight's nightly build and regression test so we can see the effect tomorrow.

The PR build for #10842 was failing due to the wget failure. I have restarted it manually. I will keep an eye on it.

[perost]

#10844 should fix the issues that occured due to the inlining. The issue was that size({vol.X_start[1:vol.Medium.nXi]}, 1) was constant evaluated to vol.nX, because the evaluation of size didn't actually evaluate the dimension size. With that fixed it now properly evaluates everything and there's no equation being created.