Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of function parameter variability #10836

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

perost
Copy link
Member

@perost perost commented Jun 14, 2023

  • Remove variability prefixes from function parameters since they have no semantic meaning, to avoid e.g. function inputs being constant evaluated.
  • Add some debug output from EvalFunction using the existing evalFuncDump debug flag.

Fixes #10828

@perost perost added the COMP/OMC/Frontend Issue and pull request related to the frontend label Jun 14, 2023
@perost perost self-assigned this Jun 14, 2023
@perost perost enabled auto-merge (squash) June 14, 2023 11:40
- Remove variability prefixes from function parameters since they have
  no semantic meaning, to avoid e.g. function inputs being constant
  evaluated.
- Add annotation '__OpenModelica_functionVariability' to keep the
  variability regardless, which is useful for defining some of the
  builtin functions.
- Add some debug output from EvalFunction using the existing
  evalFuncDump debug flag.

Fixes OpenModelica#10828
@perost perost merged commit b2f623e into OpenModelica:master Jun 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMP/OMC/Frontend Issue and pull request related to the frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assert from within algorithm section during model check
1 participant