Fix slow marking of nonlinear iteration vars #11312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes OpenModelica#11302 For each SCC of the system all variables were traversed, so the time complexity was O(N*S) where N is the number of variables and S is the number of SCCs. By first collecting all nonlinear iteration vars in the same set and then marking them once it should now be O(N).
phannebohm
force-pushed
the
11302-slow-mark-nonlinvars
branch
from
25b1076
to
2377b5b
Compare
|
Oops, @mahge I guess we both fooled around with Jenkins simultaneously 😅 |
Ya I restarted it when it failed. It seems to be running now. Let see. |
|
Looks like it worked, see latest regression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes #11302
Purpose
For each SCC of the system all variables were traversed, so the time complexity was O(N*S) where N is the number of variables and S is the number of SCCs.
Approach
By first collecting all nonlinear iteration vars in the same set and then marking them once it should now be O(N).