Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open edit component #11423

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Conversation

MaksKBV
Copy link
Contributor

@MaksKBV MaksKBV commented Oct 21, 2023

Related Issues

Edit replaceble elements problem #11422

Approach

Take full qualified name of edit component relatively main model and not element

@adeas31 adeas31 self-requested a review October 23, 2023 11:33
Copy link
Member

@adeas31 adeas31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and it also works. But I think we should guard against the null pointer. A model not always have a parent element so its better to check if its null or not.

@MaksKBV
Copy link
Contributor Author

MaksKBV commented Oct 25, 2023

I found some cases when it still not work. I will fix it and add null check when I can

@adeas31 adeas31 merged commit 37638a7 into OpenModelica:master Nov 14, 2023
2 checks passed
adeas31 pushed a commit to adeas31/OpenModelica that referenced this pull request Nov 14, 2023
* Take qualify path from main model and not from component in edit
rediclare model

* Add ligoc for inheritable. Add null check.
adeas31 pushed a commit that referenced this pull request Nov 14, 2023
* Take qualify path from main model and not from component in edit
rediclare model

* Add ligoc for inheritable. Add null check.
perost pushed a commit to perost/OpenModelica that referenced this pull request Nov 15, 2023
* Take qualify path from main model and not from component in edit
rediclare model

* Add ligoc for inheritable. Add null check.
perost pushed a commit to perost/OpenModelica that referenced this pull request Nov 15, 2023
* Take qualify path from main model and not from component in edit
rediclare model

* Add ligoc for inheritable. Add null check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants