[runtime] No memory allocation during Kinsol F scaling function #11455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't allocate additional Jacobian matrix and work arrays for each call. - Reuse already existing Jacobian, allocate work vectors only once and only if needed
AnHeuermann
force-pushed
the
less-alloc
branch
from
4a7a403
to
9e3a5ac
Compare
|
Very good! |
casella
added
the
COMP/OMC/Runtime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
While solving #11454 I noticed that we allocate and free large matrices all the time.
Purpose
Less memory allocation = more speedz!
Approach
Don't do that. Allocate once and only if needed.