Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt6 #11581

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Qt6 #11581

wants to merge 6 commits into from

Conversation

jschueller
Copy link
Contributor

@jschueller jschueller commented Nov 15, 2023

Requires #11569, not finished

  • many changes are related to QRegExp which is deprecated in favor of QRegularExpression that is already available in qt5
    the problem is that the variables widgets relies on the different pattern syntaxes QRegExp offers but are not available in QRegularExpression, it would be simpler to only support perl expression (and wildcards maybe) so that everything could be moved to QRegularExpression and not duplicate some code

  • many changes are related to qwt which must be bumped to 6.2

maybe I should split some of these changes in several PRs, what do you think ?

@adeas31
Copy link
Member

adeas31 commented Apr 2, 2024

many changes are related to QRegExp which is deprecated in favor of QRegularExpression that is already available in qt5
the problem is that the variables widgets relies on the different pattern syntaxes QRegExp offers but are not available in QRegularExpression, it would be simpler to only support perl expression (and wildcards maybe) so that everything could be moved to QRegularExpression and not duplicate some code

I agree. The default right now is perl pattern matching syntax and I don't think people are actually using other pattern syntaxes.

maybe I should split some of these changes in several PRs, what do you think ?

Yes please. Its too many files to review at one go. Split into several PRs and I will start reviewing them. Thanks!

@adeas31 adeas31 added CI/Build MINGW Build pull request with Windows MSYS2 MINGW64 CI/Build MSYS2-UCRT64 Build pull request with Windows MSYS2 UCRT64 labels Apr 15, 2024
Copy link
Member

@adeas31 adeas31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

qRegisterMetaTypeStreamOperators<RecentFile>("RecentFile");
qRegisterMetaTypeStreamOperators<FindTextOM>("FindTextOM");
qRegisterMetaTypeStreamOperators<DebuggerConfiguration>("DebuggerConfiguration");
#endif
Copy link
Member

@adeas31 adeas31 Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we not required to register our own types?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems that was only required for qt5

@adeas31
Copy link
Member

adeas31 commented Apr 15, 2024

I will merge this one after we are done with 1.23 release. I should have reviewed it earlier but sorry I couldn't manage the time.

Regarding PatternSyntax, I believe you will make a separate PR once this is merged.

@adeas31
Copy link
Member

adeas31 commented Apr 15, 2024

The compiled OMEdit crashes on startup with,

Thread 1 "OMEdit" received signal SIGABRT, Aborted.
__pthread_kill_implementation (no_tid=0, signo=6, threadid=140736846681536) at ./nptl/pthread_kill.c:44
44      ./nptl/pthread_kill.c: No such file or directory.

OMShell output only prints first character,

image

OMNotebook is completely off,

image

@jschueller
Copy link
Contributor Author

OMEdit crashes in webengine libs on ubuntu 22 (qt 6.2), but ok on arch (qt 6.7)
which qt version did you test ?

@adeas31
Copy link
Member

adeas31 commented Apr 17, 2024

lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 22.04.4 LTS
Release:        22.04
Codename:       jammy
qmake6 --version
QMake version 3.1
Using Qt version 6.2.4 in /usr/lib/x86_64-linux-gnu

I don't know how else I can test this. There is Arch WSL at the Microsoft store. I will try that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/Build MINGW Build pull request with Windows MSYS2 MINGW64 CI/Build MSYS2-UCRT64 Build pull request with Windows MSYS2 UCRT64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants