New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qt6 #11581
base: master
Are you sure you want to change the base?
Qt6 #11581
Conversation
de2a054
to
3f75342
Compare
I agree. The default right now is perl pattern matching syntax and I don't think people are actually using other pattern syntaxes.
Yes please. Its too many files to review at one go. Split into several PRs and I will start reviewing them. Thanks! |
44a8aba
to
602f82f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
qRegisterMetaTypeStreamOperators<RecentFile>("RecentFile"); | ||
qRegisterMetaTypeStreamOperators<FindTextOM>("FindTextOM"); | ||
qRegisterMetaTypeStreamOperators<DebuggerConfiguration>("DebuggerConfiguration"); | ||
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we not required to register our own types?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems that was only required for qt5
I will merge this one after we are done with 1.23 release. I should have reviewed it earlier but sorry I couldn't manage the time. Regarding PatternSyntax, I believe you will make a separate PR once this is merged. |
The compiled OMEdit crashes on startup with,
OMShell output only prints first character, OMNotebook is completely off, |
OMEdit crashes in webengine libs on ubuntu 22 (qt 6.2), but ok on arch (qt 6.7) |
I don't know how else I can test this. There is Arch WSL at the Microsoft store. I will try that. |
Requires #11569, not finished
many changes are related to QRegExp which is deprecated in favor of QRegularExpression that is already available in qt5
the problem is that the variables widgets relies on the different pattern syntaxes QRegExp offers but are not available in QRegularExpression, it would be simpler to only support perl expression (and wildcards maybe) so that everything could be moved to QRegularExpression and not duplicate some code
many changes are related to qwt which must be bumped to 6.2
maybe I should split some of these changes in several PRs, what do you think ?