[OMEdit] Simplify visual properties of visualizers #11666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adeas31 May I ask you to review this one too, please? |
anotheruserofgithub
force-pushed
the
simplify_visual_properties
branch
from
dbea48c
to
0be2b76
Compare
anotheruserofgithub
force-pushed
the
simplify_visual_properties
branch
from
0be2b76
to
8757363
Compare
|
Apparently the CI pipeline has issues cloning OM: |
Yes, the servers are off right now. Hopefully, will be up soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
PR #10355.
Purpose
Simplify template specialization of visual properties.
get(), this could be done upstream.getDefault()andget()is tedious and does not provide any interesting feature.Approach
Merge template specializations of
getDefault()andget()into a protected methodgetProperty()that is called byget()only when the property is not custom.