Fix rotated text rendering #11691
Merged
Fix rotated text rendering #11691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
adeas31
reviewed
Dec 7, 2023
| */ | ||
| QString textToDraw = textString; | ||
| if (absMappedBoundingRect.width() > 1 && ((mFontSize <= 0 && painter->font().pointSizeF() <= Helper::minimumTextFontSize) || (mFontSize > 0 && !Utilities::isMultiline(textString)))) { | ||
| if (mappedBoundingRect.width() > 1 && ((mFontSize <= 0 && painter->font().pointSizeF() <= Helper::minimumTextFontSize) || mFontSize > 0)) { |
There was a problem hiding this comment.
Please put the comment back and check for multiline. It is not possible to get the elided text for multiline strings.
adeas31
approved these changes
Jan 26, 2024
adeas31
pushed a commit
to adeas31/OpenModelica
that referenced
this pull request
Jan 26, 2024
* Fix rotated text rendering * Merge recent changes.
adeas31
added a commit
that referenced
this pull request
Jan 26, 2024
This was referenced Jan 26, 2024
This was referenced Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Some issues with text transformation
#11625
#8236
#10650
Purpose
Some text rendering issue when it flipped or rotated. Also aligment issue when text flipped or rotated.
Suppress #11631
Approach
Based on @MaksKBV commit. Issues discovered by @adeas31 have been fixed.