Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enumeration connectors in instance API #11733

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

perost
Copy link
Member

@perost perost commented Dec 15, 2023

  • Dump the actual restriction of enumeration types rather than using enumeration, since enumeration is not a restriction but a type.
  • Dump the full extends chain for an enumeration type, terminating in an extends of enumeration to indicate an enumeration type.
  • Refactor the fetching of connector elements in OMEdit into a getConnectorElement method to avoid repetition.

Fixes #11726

@perost perost added COMP/GUI/OMEdit Issue and pull request related to OMEdit COMP/GUI/InstBased Interface Issues with new instantiation-based OMEdit feature labels Dec 15, 2023
@perost perost self-assigned this Dec 15, 2023
@perost perost enabled auto-merge (squash) December 15, 2023 12:06
- Dump the actual restriction of enumeration types rather than using
  `enumeration`, since `enumeration` is not a restriction but a type.
- Dump the full extends chain for an enumeration type, terminating in an
  extends of `enumeration` to indicate an enumeration type.
- Refactor the fetching of connector elements in OMEdit into a
  `getConnectorElement` method to avoid repetition.

Fixes OpenModelica#11726
@perost perost merged commit 3a5196b into OpenModelica:master Dec 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMP/GUI/InstBased Interface Issues with new instantiation-based OMEdit feature COMP/GUI/OMEdit Issue and pull request related to OMEdit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connectors with Type Enum won't show and raise error.
1 participant