Fail on parameters without binding or start value #11805
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phannebohm
added
the
COMP/OMC/Backend
phannebohm
force-pushed
the
10386-parameter-without-binding
branch
from
451b2c2
to
16d4da1
Compare
|
What's the plan with this PR? I've just implemented the check in the frontend as discussed in #10386 but haven't created a PR yet, but it's going to conflict with this PR due to the changed error messages. If this is still something we want I can just wait for this to be merged so I can fix the conflicts on my side. |
|
No go ahead, I'll rebase this PR later or close it if it's not needed anymore 🙂 |
phannebohm
force-pushed
the
10386-parameter-without-binding
branch
from
16d4da1
to
eb71d88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#10386
Purpose
MLS 3.6 no longer defines default start values for predefined types, so fixed parameters without binding or start attribute cannot be assigned any value. So the model should be rejected.
Approach
BackendVariable.varBindExpStartValuecan fail now when neither binding nor start attribute exists.I'm not sure if that is desired behavior in all cases. I tried my best to understand the surrounding code.