Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if delayTime is larger than delayMax #11893

Merged

Conversation

phannebohm
Copy link
Contributor

Purpose

For varying delay times we had some bogus results if delayTime > delayMax.

Approach

Check and abort simulation if delayTime is too large.

@phannebohm phannebohm added the COMP/SimRT/C Issues and pull requests related to C simulation runtime. label Jan 26, 2024
@phannebohm phannebohm self-assigned this Jan 26, 2024
@phannebohm phannebohm enabled auto-merge (squash) January 26, 2024 17:09
@phannebohm
Copy link
Contributor Author

phannebohm commented Feb 1, 2024

This PR is going way beyond what the title says now 😅
But I can't solve one part without solving everything else, otherwise it won't pass the tests...

@phannebohm
Copy link
Contributor Author

I'm going to make this PR smaller again and split these changes into separate PRs!

@phannebohm phannebohm reopened this Feb 2, 2024
@phannebohm phannebohm merged commit b28bd3f into OpenModelica:master Feb 2, 2024
2 checks passed
@phannebohm phannebohm deleted the 11836-delay-time-scaling branch February 2, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMP/SimRT/C Issues and pull requests related to C simulation runtime.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant