-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select the Element with its drawn shapes instead of boundingRect #11928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helps with the issue OpenModelica#11866
adeas31
added a commit
to adeas31/OpenModelica
that referenced
this pull request
Feb 12, 2024
Related to OpenModelica#11866 This replaces the code implemented in PRs OpenModelica#11928 and OpenModelica#11968 The new implementation selects the item using the smallest possible bounding box that contains the shapes of the item.
adeas31
added a commit
to adeas31/OpenModelica
that referenced
this pull request
Feb 12, 2024
Related to OpenModelica#11866 This replaces the code implemented in PRs OpenModelica#11928 and OpenModelica#11968 The new implementation selects the item using the smallest possible bounding box that contains the shapes of the item.
adeas31
added a commit
that referenced
this pull request
Feb 12, 2024
adeas31
added a commit
to adeas31/OpenModelica
that referenced
this pull request
Feb 13, 2024
adeas31
added a commit
to adeas31/OpenModelica
that referenced
this pull request
Feb 13, 2024
Related to OpenModelica#11866 This replaces the code implemented in PRs OpenModelica#11928 and OpenModelica#11968 The new implementation selects the item using the smallest possible bounding box that contains the shapes of the item.
adeas31
added a commit
that referenced
this pull request
Feb 13, 2024
* Fix spelling/grammar of OMEdit GUI (#11724) - Change incorrect pluralization, e.g. Libraries Browser => Library Browser. - Fix inconsistent capitalization, use lower case everywhere when referring to e.g. the message browser. - Simplify most GUI headers, e.g. Library Browser => Libraries. - Hide the header of the library tree view since the library browser window itself already has a header. - Change Hide => Autohide Variable Browser in options to better describe what the option does. - Change && => and in options. * Select the Element with its drawn shapes instead of boundingRect (#11928) Helps with the issue #11866 * Reset the connection start and end elements before removing it (#11936) Should fix #11919 Updating the bounding rectangle in the QGraphicsItem::shape() triggers unwanted paint event * Do not redraw the hidden conditional port (#11938) * Avoid having unnecessary dot in the qualified name (#11955) * Copy the connector to both icon and diagram layer (#11966) Fix for #11961 Only paste the connections on diagram layer * Improve the selection of icons (#11968) When the shape is inside a component then consider it filled shape for for better selection * Do not automatically enlarge Message Browser setting (#11970) Related to #9889 The setting is disabled by default. If enabled, the message browser will not open on new messages. Instead the small messages tab bar shown will start blinking indicating that a new message is available. * Better implementation for selection of items (#11978) Related to #11866 This replaces the code implemented in PRs #11928 and #11968 The new implementation selects the item using the smallest possible bounding box that contains the shapes of the item. * Update Russian translation (#11933) Update Russian translation * Fix some issues with edit redeclerable parameter button (#11911) * Fix evaluate expressions in text strings (#11844) --------- Co-authored-by: Per Östlund <per.ostlund@liu.se> Co-authored-by: slichtzzz <90268581+slichtzzz@users.noreply.github.com> Co-authored-by: MaksKBV <145646967+MaksKBV@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Helps with the issue #11866