Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update optimizer_main.c #11979

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Update optimizer_main.c #11979

merged 3 commits into from
Feb 14, 2024

Conversation

vruge
Copy link
Member

@vruge vruge commented Feb 12, 2024

Related Issues

@ceraolo reported that the ipopt solver status is ignored.

Purpose

use return value from IpoptSolve

pass return value from ipopt
@vruge vruge marked this pull request as draft February 12, 2024 17:52
@vruge vruge marked this pull request as ready for review February 12, 2024 19:24
@vruge vruge changed the title WIP: Update optimizer_main.c Update optimizer_main.c Feb 12, 2024
Copy link
Contributor

@casella casella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too much into these details, but it seems reasonable to me

@casella
Copy link
Contributor

casella commented Feb 14, 2024

Let's see how it works, we are still far from the 1.23.0 release date, we can always roll back if there is any issue.

@casella casella merged commit 3a47d5e into OpenModelica:master Feb 14, 2024
2 checks passed
@vruge vruge deleted the patch-2 branch February 14, 2024 20:40
@phannebohm phannebohm removed their request for review February 15, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants