Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of augmented flow variables #12215

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

perost
Copy link
Member

@perost perost commented Apr 9, 2024

  • Generate default connect equations for unconnected outside flow variables that were added during augmentation of expandable connectors.

Fixes #12159

- Generate default connect equations for unconnected outside flow
  variables that were added during augmentation of expandable
  connectors.

Fixes OpenModelica#12159
@perost perost added the COMP/OMC/Frontend Issue and pull request related to the frontend label Apr 9, 2024
@perost perost self-assigned this Apr 9, 2024
@perost perost enabled auto-merge (squash) April 9, 2024 11:11
@perost perost merged commit b77f6ab into OpenModelica:master Apr 9, 2024
2 checks passed
@casella
Copy link
Contributor

casella commented Apr 10, 2024

Thanks @perost! According to the regression report, this also improved VehicleInterfaces, which uses expandable connectors, and now has a success ratio of 100%.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMP/OMC/Frontend Issue and pull request related to the frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing default connection equations for unconnected flow/effort connectors in expandable connectors
2 participants