Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate HideResult annotations #12220

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

perost
Copy link
Member

@perost perost commented Apr 10, 2024

  • Rewrite Variable.propagateAnnotation to optionally evaluate the annotation value and use it when propagating HideResult.
  • Remove the annotation field from Component.COMPONENT since it's not actually used anywhere.

@perost perost added the COMP/OMC/Frontend Issue and pull request related to the frontend label Apr 10, 2024
@perost perost self-assigned this Apr 10, 2024
@perost perost enabled auto-merge (squash) April 10, 2024 13:59
- Rewrite `Variable.propagateAnnotation` to optionally evaluate the
  annotation value and use it when propagating HideResult.
- Remove the annotation field from `Component.COMPONENT` since it's
  not actually used anywhere.
@perost perost merged commit 252fbdb into OpenModelica:master Apr 10, 2024
2 checks passed
perost added a commit to perost/OpenModelica that referenced this pull request Apr 15, 2024
- Rewrite `Variable.propagateAnnotation` to optionally evaluate the
  annotation value and use it when propagating HideResult.
- Remove the annotation field from `Component.COMPONENT` since it's
  not actually used anywhere.
perost added a commit that referenced this pull request Apr 15, 2024
* Evaluate HideResult annotations (#12220)

- Rewrite `Variable.propagateAnnotation` to optionally evaluate the
  annotation value and use it when propagating HideResult.
- Remove the annotation field from `Component.COMPONENT` since it's
  not actually used anywhere.

* Fix InstNode.getAnnotation (#12233)

- Use `instanceParent()` instead of `parent()` to properly traverse the
  instance tree when looking for annotations on parents.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMP/OMC/Frontend Issue and pull request related to the frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant