Dump annotation array elements separately #12325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
perost
commented
Apr 26, 2024
perost
commented
- Dump elements of array expressions in annotations separately, to avoid e.g. an invalid graphical element invalidating the whole graphics arrays.
- Dump elements of array expressions in annotations separately, to avoid e.g. an invalid graphical element invalidating the whole graphics arrays.
perost
added
the
COMP/GUI/InstBased Interface
|
@adeas31: This moves the invalid expression part of the schema so that any subexpression might be invalid, rather than just the whole binding expression of an annotation. It looks like OMEdit just ignores such subexpressions at the moment, so it kind of already works, but it also ignores the error messages in that case which we might want to print out. |
|
I will take care of error messages. |
adeas31
added a commit
to adeas31/OpenModelica
that referenced
this pull request
Apr 30, 2024
Adapt to the new output introduced in OpenModelica#12325
adeas31
added a commit
that referenced
this pull request
Apr 30, 2024
Adapt to the new output introduced in #12325
adeas31
pushed a commit
to adeas31/OpenModelica
that referenced
this pull request
May 7, 2024
- Dump elements of array expressions in annotations separately, to avoid e.g. an invalid graphical element invalidating the whole graphics arrays.
adeas31
added a commit
to adeas31/OpenModelica
that referenced
this pull request
May 7, 2024
Adapt to the new output introduced in OpenModelica#12325
adeas31
added a commit
that referenced
this pull request
May 7, 2024
* Dump annotation array elements separately (#12325) - Dump elements of array expressions in annotations separately, to avoid e.g. an invalid graphical element invalidating the whole graphics arrays. * Hide protected variables that belongs to an encrypted class (#12351) #11718 Ignore emit_protected flag for the protected variables that are inside encrypted model * Read the error from the graphics annotation element (#12353) Adapt to the new output introduced in #12325 * Improve check for encrypted variables (#12369) - Consider a component with an encrypted parent to also be encrypted. * Handle prefixing of time units (#12370) #12352 Fixes the regression introduced in #12221 * Instance of non encrypted class inside encrypted class (#12372) #11718 Hide non encrypted class variables when defined as protected in encrypted class * Properly handle the parameters for parametric plot (#12378) #12375 * Fix some Linux builds compilation (#12392) * Avoid extra end message tag when logging LOG_INIT (#12391) #12386 --------- Co-authored-by: Per Östlund <per.ostlund@liu.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.