Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] Index reduction update #633

Merged
merged 1 commit into from Dec 19, 2019

Conversation

kabdelhak
Copy link
Contributor

@kabdelhak kabdelhak commented Dec 16, 2019

  • consider non states as stateSelect never and make them artificial states

@kabdelhak kabdelhak force-pushed the experimentalIndexReduction branch 3 times, most recently from 0404a78 to 85fe83a Compare December 16, 2019 11:19
@kabdelhak kabdelhak force-pushed the experimentalIndexReduction branch 3 times, most recently from 54549d8 to f14e3c4 Compare December 19, 2019 16:16
@casella
Copy link
Contributor

casella commented Dec 19, 2019

Thanks @kabdelhak !

@kabdelhak
Copy link
Contributor Author

Thanks @kabdelhak !

No problem!

Unfortunately i forgot to add one more thing. I have to rerun it, but then it should be fine!

   - consider non states as stateSelect never
@casella
Copy link
Contributor

casella commented Dec 19, 2019

Thanks @kabdelhak !

No problem!

Unfortunately i forgot to add one more thing. I have to rerun it, but then it should be fine!

No problem 😃

@casella
Copy link
Contributor

casella commented Dec 19, 2019

Ready to launch!

@kabdelhak
Copy link
Contributor Author

Ready to launch!

Unfortunately we have to wait for someone with push privileges. I requested it in our slack group, i guess it will be pushed as soon as someone is able to.

@casella casella requested a review from adrpo December 19, 2019 18:31
Copy link
Member

@adrpo adrpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK by me!

@adrpo adrpo merged commit 387c3b2 into OpenModelica:master Dec 19, 2019
@adrpo
Copy link
Member

adrpo commented Dec 19, 2019

Merged and newInst coverage job started.

@kabdelhak kabdelhak deleted the experimentalIndexReduction branch March 10, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants