[NF] update discrete real check #6744
Conversation
kabdelhak
commented
Sep 10, 2020
kabdelhak
commented
- correct support for array element types
| algorithm | ||
| isReal := match ty | ||
| case REAL() then true; | ||
| case ARRAY(elementType = REAL()) then true; |
There was a problem hiding this comment.
That's no recursion. Did you mean case ARRAY() then isRealRecursive(ty.elementType);?
Or did we say goodbye to recursive arrays? 😄
There was a problem hiding this comment.
yes that is what i intended to do :D Seems like i only updated the name but not the function...
There was a problem hiding this comment.
A better name would perhaps be isRealElementType to conform to the existing names (the function is basically equivalent to Type.isReal(Type.arrayElementType(ty))).
There was a problem hiding this comment.
Yea, but i wanted to be safe if there is any form of recursion e.g. and array containing in an array containing an array etc. And it should also return true for just REAL().
There was a problem hiding this comment.
Yes, Type.arrayElementType returns either the innermost element type of an array type or the type itself.
- correct support for array element types
kabdelhak
force-pushed
the
5836_add_array
branch
from
6ad2e71
to
2e1fc97
Compare
