fixes for ticket #6013 and #6129 #6765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are the broken tests critical? |
|
Had a talk with Per, found out what the problem is and I have a fix. Will push this in soon. |
- use NFInst.expand instead of NFInst.instantiate in NFApi.mkFullyQual - fully qualify the path we search for and all the extends in the loaded libraries to make sure is the proper subtype of - a bit slow but it can be improved later - force instantiation when NF_API is on even if inner component is not found - speedup getExtendsModifierNames if there are no modifiers in extends
|
Very good! I'll get the nightly build tomorrow, test it and report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libraries to make sure is the proper subtype of