Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable -d=newInst as default. #6902

Closed
wants to merge 1 commit into from
Closed

Conversation

perost
Copy link
Member

@perost perost commented Nov 9, 2020

  • Flip the default value for the newInst debug flag.
  • Add -d=-newInst to all test cases using the old frontend.

@perost
Copy link
Member Author

perost commented Nov 9, 2020

This is something of a "let's see what happens" thing. I wrote a script that added -d=-newInst to all test cases that didn't already use the flag, but it's probably not perfect and might need some manual intervention.

But the thought is to allow us to switch the NF on by default without having to update all the testcases at the same time, and instead make it possible to update the testcases in batches at our own pace.

And of course there might be other issues that needs to be solved first, like making sure it doesn't mess up the scripting interface.

@perost
Copy link
Member Author

perost commented Nov 10, 2020

I forgot to actually commit the change that enabled the flag the first time...

- Flip the default value for the newInst debug flag.
- Add -d=-newInst to all test cases using the old frontend.
@perost
Copy link
Member Author

perost commented Nov 11, 2020

I'm closing this and opening a new PR that only changes the testsuite and not turning the NF by default, since more work is needed before that can be done.

@perost perost closed this Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant