Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy OMSens to build/share #7400

Merged
merged 1 commit into from Apr 22, 2021
Merged

Copy OMSens to build/share #7400

merged 1 commit into from Apr 22, 2021

Conversation

adeas31
Copy link
Member

@adeas31 adeas31 commented Apr 22, 2021

Related Issues

OpenModelica/OMSens#15

Purpose

Copy the OMSens folder to build/share

Approach

Added a makefile to copy files.

@adeas31 adeas31 requested a review from adrpo April 22, 2021 14:16
@adeas31 adeas31 self-assigned this Apr 22, 2021
Copy link
Member

@adrpo adrpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK with me!

@adrpo adrpo merged commit 93abcfa into OpenModelica:master Apr 22, 2021
@sjoelund
Copy link
Member

Why would it be installed in OMSens when all other of our packages use lower case? Also, isn't it a Python application? Those should not be installed in this way.

@adrpo
Copy link
Member

adrpo commented Apr 22, 2021

Yeah, i also thought we should use lower case but then I saw we have: OMSimulator with caps in there as well.

@adrpo
Copy link
Member

adrpo commented Apr 22, 2021

Yeah, one should use pip to install OMSens but that will come later, now we should just distribute the files and setup it on the user machine.

@adeas31 adeas31 deleted the omsens branch April 23, 2021 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants