Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement METARECORDCALL in Cpp runtime #7620

Merged
merged 2 commits into from
Jun 28, 2021
Merged

Implement METARECORDCALL in Cpp runtime #7620

merged 2 commits into from
Jun 28, 2021

Conversation

rfranke
Copy link
Member

@rfranke rfranke commented Jun 27, 2021 •
edited

The implementation is identical to RECORD appearing e.g. for
Modelica.Media.Examples.SolveOneNonlinearEquation.Inverse_sh_TX

Other similar examples have METARECORDCALL instead, e.g.
Modelica.Media.Examples.SolveOneNonlinearEquation.Inverse_sh_T

so far resulting in:

[CodegenCppCommon.tpl:974:14-974:14:writable] Error: Template error: Unknown exp:
Modelica.Media.IdealGases.Common.DataRecord("Air", #(0.0289651159), #(-4333.833858403446), #(298609.6803431054),
#(1000.0), #({10099.5016, -196.827561, 5.00915511, -0.00576101373, 1.06685993e-05, -7.94029797e-09, 2.18523191e-12}),
#({-176.796731, -3.921504225}), #({241521.443, -1257.8746, 5.14455867, -0.000213854179, 7.06522784e-08, -1.07148349e-11, 6.57780015e-16}),
#({6462.26319, -8.147411905}), #(287.0512249529787)).

@rfranke rfranke added bug COMP/OMC/Backend Issue and pull request related to the backend COMP/SimRT/C Issues and pull requests related to C simulation runtime. labels Jun 27, 2021
@rfranke rfranke changed the title Implement METARECORDCALL and SCONST in Cpp runtime Implement METARECORDCALL in Cpp runtime Jun 27, 2021
@adrpo adrpo enabled auto-merge (squash) June 27, 2021 16:14
@rfranke
Implement daeExp METARECORDCALL in Cpp runtime
2820448 
The implementation is identical to RECORD appearing e.g. for
Modelica.Media.Examples.SolveOneNonlinearEquation.Inverse_sh_TX

Other similar examples have METARECORDCALL instead, e.g.
Modelica.Media.Examples.SolveOneNonlinearEquation.Inverse_sh_T
auto-merge was automatically disabled June 27, 2021 16:27

Head branch was pushed to by a user without write access

@rfranke
Prepare another fix: assignment with record on lhs
b9ec016 
This only appears needed for the anyway not simulating
Modelica.Electrical.Spice3.Examples.Spice3BenchmarkFourBitBinaryAdder
@sjoelund sjoelund merged commit 3d50ca5 into OpenModelica:master Jun 28, 2021
@adrpo adrpo mentioned this pull request Jun 28, 2021
Merged
@rfranke rfranke deleted the recordcall branch June 28, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug COMP/OMC/Backend Issue and pull request related to the backend COMP/SimRT/C Issues and pull requests related to C simulation runtime.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rfranke @sjoelund