Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Windows fixes. #8123

Merged
merged 1 commit into from Nov 12, 2021
Merged

More Windows fixes. #8123

merged 1 commit into from Nov 12, 2021

Conversation

mahge
Copy link
Contributor

@mahge mahge commented Nov 12, 2021

  • The bootstrapped compiler is run from its build directory since we
    need to use during build step (as opposed to after installation like
    everything else).

    On Windows we need the dlls it uses in the same dir since there is no
    RPATH. Luckily the only dll it needs right now is OpenModelicaRuntimeC.

  • Disable autoconf based config genration for source code FMUs on Windows
    This is temporary until I can find a good way.

    Small fix for checking source fmu autoconf config generation. Report
    any errors properly.

  • Do not declare function RDTSC() as inline. Instead it should be static
    (if it needs any qualifier at all)

  • Disable command line compile definition WITH_IPOPT for now. The define
    is already hard coded in omc_config.h. Which means this leads to warnings
    for every compilation unit. Until we remove the hard coded definition
    in omc_config.h disable this one.

  - The bootstrapped compiler is run from its build directory since we
    need to use during build step (as opposed to after installation like
    everything else).

    On Windows we need the dlls it uses in the same dir since there is no
    RPATH. Luckily the only dll it needs right now is OpenModelicaRuntimeC.

  - Disable autoconf based config genration for source code FMUs on Windows
    This is temporary until I can find a good way.

    Small fix for checking source fmu autoconf config generation. Report
    any errors properly.

  - Do not declare function RDTSC() as inline. Instead it should be static
    (if it needs any qualifier at all)

  - Disable command line compile definition WITH_IPOPT for now. The define
    is already hard coded in omc_config.h. Which means this leads to warnings
    for every compilation unit. Until we remove the hard coded definition
    in omc_config.h disable this one.
@mahge mahge enabled auto-merge (squash) November 12, 2021 12:05
@mahge mahge merged commit 2e9ac99 into OpenModelica:master Nov 12, 2021
@mahge mahge deleted the cmake_windows_fixes branch November 12, 2021 12:24
@mahge mahge self-assigned this Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant