Disable autosetting of optimization flags by libffi. #8996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahge
added
COMP/Build System
- Disable the setting of optimization flags. automatically by libffi's
own decisions. For OpenModelica we want to pass the options and flags
ourselves.
This was ignoring all CFLAGS we pass to libffi including `-fPIC`
breaking the build of OpenModelica on Fedora 36 because the libray
could not be linked to a shared library (since it was not compiled as
position independent code.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable the setting of optimization flags. automatically by libffi's
own decisions. For OpenModelica we want to pass the options and flags
ourselves.
This was ignoring all CFLAGS we pass to libffi including
-fPICbreaking the build of OpenModelica on Fedora 36 because the libray
could not be linked to a shared library (since it was not compiled as
position independent code.)