Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update OMSProxy addConnection #9006

Merged
merged 2 commits into from May 23, 2022
Merged

update OMSProxy addConnection #9006

merged 2 commits into from May 23, 2022

Conversation

arun3688
Copy link
Contributor

@arun3688 arun3688 commented May 23, 2022 •
edited

Purpose

This PR updates OMEdit oms_addConnection API with the OMSimulator oms_addConnection

NOTE

This PR should be merged with updating OMSimulator submodule

@arun3688 arun3688 added the COMP/GUI/OMEdit Issue and pull request related to OMEdit label May 23, 2022
@arun3688 arun3688 requested a review from adeas31 May 23, 2022 14:56
adeas31
adeas31 approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@adeas31 adeas31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Update the OMSimulator submodule with this PR to get rid of build errors.

@arun3688 arun3688 added the COMP/OMSimulator Issue and pull request related to OMSimulator label May 23, 2022
@arun3688
Copy link
Contributor Author

@adeas31 Updated the OMSimulator Module with this 2aac051

@lochel lochel merged commit 20cf387 into OpenModelica:master May 23, 2022
@arun3688 arun3688 deleted the oms_connection branch May 23, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adeas31 adeas31 adeas31 approved these changes

Assignees
No one assigned
Labels
COMP/GUI/OMEdit Issue and pull request related to OMEdit COMP/OMSimulator Issue and pull request related to OMSimulator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arun3688 @adeas31 @lochel