Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove simulation option -exInputFile. #9518

Merged
merged 2 commits into from Oct 14, 2022
Merged

Conversation

mahge
Copy link
Contributor

@mahge mahge commented Oct 14, 2022

  • The functionality of this option was very similar to -csvInput. The only differences were:

    • exInputFile accepted space separated CSV files only.
    • exInputFile always looked for a default file called externalInput.csv
      if no file was explicitly specified.
  • The flag is redundant and confusing. Its functionality can be achieved by -csvInput.

  • Fixes -exInputFile doesn't work #9488.

  - The functionality of this option was very similar to `-csvInput`. The
    only differences were:

      - `exInputFile` accepted space separated CSV files only.
      - `exInputFile` always looked for a default file called `externalInput.csv`
        if no file was explicitly specified.

  - The flag is redundant and confusing. Its functionality can be achieved
    by `-csvInput`.

  - Fixes OpenModelica#9488.
@mahge mahge added the COMP/SimRT/C Issues and pull requests related to C simulation runtime. label Oct 14, 2022
@mahge mahge self-assigned this Oct 14, 2022
@mahge mahge mentioned this pull request Oct 14, 2022
@mahge mahge merged commit 7cc2dd0 into OpenModelica:master Oct 14, 2022
@mahge mahge deleted the ticket_9488 branch October 14, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMP/SimRT/C Issues and pull requests related to C simulation runtime.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

-exInputFile doesn't work
1 participant